marko/ansible-role-aide
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: tox-lsr 3.17.1 - previous update broke container tests, this fixes them [citest_skip]

Browse Source 
tox-lsr 3.17.1 has a fix for the broken container tests

There was one shell function for both setting up the callback plugins and the connection plugin.
When this function was skipped, the ANSIBLE_CONNECTION_PLUGINS environment variable was not
set, so all subsequent tests failed.  The connection plugin must be present and the env. var.
must be set in order to run any container tests.  The code was fixed to ensure that there is
always a connection plugin installed in the correct location and that ANSIBLE_CONNECTION_PLUGINS
is always set and contains this path.

Also, setting up the callback plugins and the connection plugin is already idempotent, so no
reason to skip them.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This commit is contained in:
Rich Megginson
2026-03-13 10:06:05 -06:00
committed by Richard Megginson
parent e1680b64f1
commit 84a356a028
4 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ansible-lint.yml
+1 -1
View File
@@ -35,7 +35,7 @@ jobs:
- name: Install tox, tox-lsr - name: Install tox, tox-lsr
run: | run: |
set -euxo pipefail set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.0" pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.1"
- name: Convert role to collection format - name: Convert role to collection format
id: collection id: collection
.github/workflows/ansible-managed-var-comment.yml
+1 -1
View File
@@ -33,7 +33,7 @@ jobs:
- name: Install tox, tox-lsr - name: Install tox, tox-lsr
run: | run: |
set -euxo pipefail set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.0" pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.1"
- name: Run ansible-plugin-scan - name: Run ansible-plugin-scan
run: | run: |
.github/workflows/ansible-test.yml
+1 -1
View File
@@ -36,7 +36,7 @@ jobs:
- name: Install tox, tox-lsr - name: Install tox, tox-lsr
run: | run: |
set -euxo pipefail set -euxo pipefail
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.0" pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.1"
- name: Convert role to collection format - name: Convert role to collection format
run: | run: |
.github/workflows/qemu-kvm-integration-tests.yml
+1 -3
View File
@@ -110,7 +110,7 @@ jobs:
python3 -m pip install --upgrade pip python3 -m pip install --upgrade pip
sudo apt update sudo apt update
sudo apt install -y --no-install-recommends git ansible-core genisoimage qemu-system-x86 sudo apt install -y --no-install-recommends git ansible-core genisoimage qemu-system-x86
pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.0" pip3 install "git+https://github.com/linux-system-roles/tox-lsr@3.17.1"
# HACK: Drop this when moving this workflow to 26.04 LTS # HACK: Drop this when moving this workflow to 26.04 LTS
- name: Update podman to 5.x for compatibility with bootc-image-builder's podman 5 - name: Update podman to 5.x for compatibility with bootc-image-builder's podman 5
@@ -178,7 +178,6 @@ jobs:
rc=0 rc=0
# we cannot skip these on the first test # we cannot skip these on the first test
export SKIP_REQUIREMENTS=false export SKIP_REQUIREMENTS=false
export SKIP_CALLBACK_PLUGINS=false
for t in tests/tests_*.yml; do for t in tests/tests_*.yml; do
if tox -e ${{ matrix.scenario.env }} -- --image-name ${{ matrix.scenario.image }} $t > ${t}.log 2>&1; then if tox -e ${{ matrix.scenario.env }} -- --image-name ${{ matrix.scenario.image }} $t > ${t}.log 2>&1; then
echo "PASS: $(basename $t)" echo "PASS: $(basename $t)"
@@ -190,7 +189,6 @@ jobs:
fi fi
# we can skip these on subsequent runs # we can skip these on subsequent runs
export SKIP_REQUIREMENTS=true export SKIP_REQUIREMENTS=true
export SKIP_CALLBACK_PLUGINS=true
done done
exit $rc exit $rc