marko/ansible-role-aide
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: use ANSIBLE_INJECT_FACT_VARS=false by default for testing

Browse Source 
Ansible 2.20 has deprecated the use of Ansible facts as variables.  For
example, `ansible_distribution` is now deprecated in favor of
`ansible_facts["distribution"]`.  This is due to making the default
setting `INJECT_FACTS_AS_VARS=false`.  For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

In order to ensure that commits and PRs conform to this, use
ANSIBLE_INJECT_FACT_VARS=false by default in our CI testing.

Update README-ostree.md if needed.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
This commit is contained in:
Rich Megginson
2026-01-13 10:33:02 -05:00
committed by Richard Megginson
parent 7ac5ab66d7
commit b1f77838d2
3 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/qemu-kvm-integration-tests.yml
+1
View File
@@ -44,6 +44,7 @@ jobs:
env: env:
TOX_ARGS: "--skip-tags tests::infiniband,tests::nvme,tests::scsi" TOX_ARGS: "--skip-tags tests::infiniband,tests::nvme,tests::scsi"
ANSIBLE_INJECT_FACT_VARS: "false"
steps: steps:
- name: Checkout repo - name: Checkout repo
.github/workflows/tft.yml
+1
View File
@@ -168,6 +168,7 @@ jobs:
SR_ARTIFACTS_DIR=${{ steps.set_vars.outputs.ARTIFACTS_DIR }};\ SR_ARTIFACTS_DIR=${{ steps.set_vars.outputs.ARTIFACTS_DIR }};\
SR_TEST_LOCAL_CHANGES=false;\ SR_TEST_LOCAL_CHANGES=false;\
SR_LSR_USER=${{ vars.SR_LSR_USER }};\ SR_LSR_USER=${{ vars.SR_LSR_USER }};\
SR_ANSIBLE_INJECT_FACT_VARS=false;\
SR_ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }}" SR_ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }}"
# Note that LINUXSYSTEMROLES_SSH_KEY must be single-line, TF doesn't read multi-line variables fine. # Note that LINUXSYSTEMROLES_SSH_KEY must be single-line, TF doesn't read multi-line variables fine.
secrets: "SR_LSR_DOMAIN=${{ secrets.SR_LSR_DOMAIN }};\ secrets: "SR_LSR_DOMAIN=${{ secrets.SR_LSR_DOMAIN }};\
README-ostree.md
+2 -2
View File
@@ -20,8 +20,8 @@ Usage:
.ostree/get_ostree_data.sh packages runtime DISTRO-VERSION FORMAT .ostree/get_ostree_data.sh packages runtime DISTRO-VERSION FORMAT
``` ```
`DISTRO-VERSION` is in the format that Ansible uses for `ansible_distribution` `DISTRO-VERSION` is in the format that Ansible uses for `ansible_facts["distribution"]`
and `ansible_distribution_version` - for example, `Fedora-38`, `CentOS-8`, and `ansible_facts["distribution_version"]` - for example, `Fedora-38`, `CentOS-8`,
`RedHat-9.4` `RedHat-9.4`
`FORMAT` is one of `toml`, `json`, `yaml`, `raw` `FORMAT` is one of `toml`, `json`, `yaml`, `raw`