We have a lot of requests to support Rocky and Alma in various system roles. The first part of adding support is adding `vars/` files for these platforms. In almost every case, for a given major version N, the vars file RedHat_N.yml can be used for CentOS, Rocky, and Alma. Rather than making a copy of the RedHat_N.yml file, just use a symlink to reduce size and maintenance burden, and standardize this across all system roles for consistency. NOTE: There is no Alma or Rocky version 7 or less. NOTE: OracleLinux is not a strict clone, so we are not going to do this for OracleLinux at this time. Support for OracleLinux will need to be done in separate PRs. For more information, see https://github.com/linux-system-roles/cockpit/issues/130 **Question**: Why not just use `ansible_facts["os_family"] == "RedHat"`? **Answer**: This is what Ansible uses as the RedHat os_family: https://github.com/ansible/ansible/blob/1e6ffc1d02559a26def6c9c3b07baf27032865a2/lib/ansible/module_utils/facts/system/distribution.py#L511 There are a lot of distributions in there. I know that Fedora is not a clone of RHEL, but it is very closely related. Most of the others are not clones, and it would generally not work to replace ansible_distribution in ['CentOS', 'Fedora', 'RedHat'] with ansible_facts['os_family'] == 'RedHat' (but it would probably work in specific cases with specific distributions). For example, OracleLinux is in there, and we know that doesn't generally work. The only ones we can be pretty sure about are `RedHat`, `CentOS`, `Fedora`, `AlmaLinux`, and `Rocky`. **Question**: Does my role really need this because it should already work on RHEL clones? **Answer**: Maybe not - but: * it doesn't hurt anything * it's there if we need it in the future * the role will be inconsistent with the other system roles if we don't have this **Question**: Why do I need the `tests/vars/rh_distros_vars.yml` file? Doesn't the test load the vars from the role? **Answer**: No, the test does not load the vars from the role until the role is included, and many tests use version and distribution before including the role. **Question**: Do we need to change the code now to use the new variables? **Answer**: No, not now, in subsequent PRs, hopefully by Alma and Rocky users. Note that there may be more work to be done to the role to fully support Rocky and Alma. Many roles have conditionals like this: ```yaml some_var: "{{ 'some value' if ansible_distribution in ['CentOS', 'RedHat'] else 'other value' }}" another_var: "{{ 'some value' if ansible_distribution in ['CentOS', 'Fedora', 'RedHat'] else 'other value' }}" ... - name: Do something when: ansible_distribution in ['CentOS', 'RedHat'] ... - name: Do something else when: ansible_distribution in ['CentOS', 'Fedora', 'RedHat'] ... ``` Adding Rocky and AlmaLinux to these conditionals will have to be done separately. In order to simplify the task, some new variables are being introduced: ```yaml __$rolename_rh_distros: - AlmaLinux - CentOS - RedHat - Rocky __$rolename_rh_distros_fedora: "{{ __$rolename_rh_distros + ['Fedora'] }}" __$rolename_is_rh_distro: "{{ ansible_distribution in __$rolename_rh_distros }}" __$rolename_is_rh_distro_fedora: "{{ ansible_distribution in __$rolename_rh_distros_fedora }}" ``` Then the conditionals can be rewritten as: ```yaml some_var: "{{ 'some value' if __$rolename_is_rh_distro else 'other value' }}" another_var: "{{ 'some value' if __$rolename_is_rh_distro_fedora else 'other value' }}" ... - name: Do something when: __$rolename_is_rh_distro | bool ... - name: Do something else when: __$rolename_is_rh_distro_fedora | bool ... ``` For tests - tests that use such conditionals will need to use `vars_files` or `include_vars` to load the variables that are defined in `tests/vars/rh_distros_vars.yml`: ```yaml vars_files: - vars/rh_distros_vars.yml ``` We don't currently have CI testing for Rocky or Alma, so someone wanting to run tests on those platforms would need to change the test code to use these. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
195 lines
8.5 KiB
YAML
195 lines
8.5 KiB
YAML
---
|
|
name: Run integration tests in Testing Farm
|
|
on:
|
|
issue_comment:
|
|
types:
|
|
- created
|
|
permissions:
|
|
contents: read
|
|
# This is required for the ability to create/update the Pull request status
|
|
statuses: write
|
|
jobs:
|
|
prepare_vars:
|
|
name: Get info from role and PR to determine if and how to test
|
|
# The concurrency key is used to prevent multiple workflows from running at the same time
|
|
concurrency:
|
|
# group name contains reponame-pr_num to allow simualteneous runs in different PRs
|
|
group: testing-farm-${{ github.event.repository.name }}-${{ github.event.issue.number }}
|
|
cancel-in-progress: true
|
|
# Let's schedule tests only on user request. NOT automatically.
|
|
# Only repository owner or member can schedule tests
|
|
if: |
|
|
github.event.issue.pull_request
|
|
&& contains(github.event.comment.body, '[citest]')
|
|
&& (contains(fromJson('["OWNER", "MEMBER", "COLLABORATOR", "CONTRIBUTOR"]'), github.event.comment.author_association)
|
|
|| contains('systemroller', github.event.comment.user.login))
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
supported_platforms: ${{ steps.supported_platforms.outputs.supported_platforms }}
|
|
head_sha: ${{ steps.head_sha.outputs.head_sha }}
|
|
memory: ${{ steps.memory.outputs.memory }}
|
|
steps:
|
|
- name: Dump github context
|
|
run: echo "$GITHUB_CONTEXT"
|
|
shell: bash
|
|
env:
|
|
GITHUB_CONTEXT: ${{ toJson(github) }}
|
|
|
|
- name: Checkout repo
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Get head sha of the PR
|
|
id: head_sha
|
|
run: |
|
|
head_sha=$(gh api "repos/$REPO/pulls/$PR_NO" --jq '.head.sha')
|
|
echo "head_sha=$head_sha" >> $GITHUB_OUTPUT
|
|
env:
|
|
REPO: ${{ github.repository }}
|
|
PR_NO: ${{ github.event.issue.number }}
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Checkout PR
|
|
uses: actions/checkout@v4
|
|
with:
|
|
ref: ${{ steps.head_sha.outputs.head_sha }}
|
|
|
|
- name: Get memory
|
|
id: memory
|
|
run: |
|
|
if [ -d tests/provision.fmf ]; then
|
|
memory=$(grep -rPo ' m: \K(.*)' tests/provision.fmf)
|
|
fi
|
|
if [ -n "$memory" ]; then
|
|
echo "memory=$memory" >> $GITHUB_OUTPUT
|
|
else
|
|
echo "memory=2048" >> $GITHUB_OUTPUT
|
|
fi
|
|
|
|
- name: Get supported platforms
|
|
id: supported_platforms
|
|
run: |
|
|
supported_platforms=""
|
|
meta_main=meta/main.yml
|
|
# All Fedora are supported, add latest Fedora versions to supported_platforms
|
|
if yq '.galaxy_info.galaxy_tags[]' "$meta_main" | grep -qi fedora$; then
|
|
supported_platforms+=" Fedora-39"
|
|
supported_platforms+=" Fedora-40"
|
|
fi
|
|
# Specific Fedora versions supported
|
|
if yq '.galaxy_info.galaxy_tags[]' "$meta_main" | grep -qiP 'fedora\d+$'; then
|
|
for fedora_ver in $(yq '.galaxy_info.galaxy_tags[]' "$meta_main" | grep -iPo 'fedora\K(\d+$)'); do
|
|
supported_platforms+=" Fedora-$fedora_ver"
|
|
done
|
|
fi
|
|
if yq '.galaxy_info.galaxy_tags[]' "$meta_main" | grep -qi el7; then
|
|
supported_platforms+=" CentOS-7-latest"
|
|
fi
|
|
for ver in 8 9 10; do
|
|
if yq '.galaxy_info.galaxy_tags[]' "$meta_main" | grep -qi el"$ver"; then
|
|
supported_platforms+=" CentOS-Stream-$ver"
|
|
fi
|
|
done
|
|
echo "supported_platforms=$supported_platforms" >> $GITHUB_OUTPUT
|
|
|
|
testing-farm:
|
|
name: ${{ matrix.platform }}/ansible-${{ matrix.ansible_version }}
|
|
needs: prepare_vars
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- platform: Fedora-39
|
|
ansible_version: 2.17
|
|
- platform: Fedora-40
|
|
ansible_version: 2.17
|
|
- platform: CentOS-7-latest
|
|
ansible_version: 2.9
|
|
- platform: CentOS-Stream-8
|
|
ansible_version: 2.9
|
|
# On CentOS-Stream-8, latest supported Ansible is 2.16
|
|
- platform: CentOS-Stream-8
|
|
ansible_version: 2.16
|
|
- platform: CentOS-Stream-9
|
|
ansible_version: 2.17
|
|
- platform: CentOS-Stream-10
|
|
ansible_version: 2.17
|
|
runs-on: ubuntu-latest
|
|
env:
|
|
ARTIFACTS_DIR_NAME: "tf_${{ github.event.repository.name }}-${{ github.event.issue.number }}_\
|
|
${{ matrix.platform }}-${{ matrix.ansible_version }}_\
|
|
${{ needs.prepare_vars.outputs.datetime }}/artifacts"
|
|
ARTIFACT_TARGET_DIR: /srv/pub/alt/${{ vars.LINUXSYSTEMROLES_USER }}/logs
|
|
steps:
|
|
- name: Set variables with DATETIME and artifact location
|
|
id: set_vars
|
|
run: |
|
|
printf -v DATETIME '%(%Y%m%d-%H%M%S)T' -1
|
|
ARTIFACTS_DIR_NAME="tf_${{ github.event.repository.name }}-${{ github.event.issue.number }}_\
|
|
${{ matrix.platform }}-${{ matrix.ansible_version }}_$DATETIME/artifacts"
|
|
ARTIFACTS_TARGET_DIR=/srv/pub/alt/${{ vars.LINUXSYSTEMROLES_USER }}/logs
|
|
ARTIFACTS_DIR=$ARTIFACTS_TARGET_DIR/$ARTIFACTS_DIR_NAME
|
|
ARTIFACTS_URL=https://dl.fedoraproject.org/pub/alt/${{ vars.LINUXSYSTEMROLES_USER }}/logs/$ARTIFACTS_DIR_NAME
|
|
echo "DATETIME=$DATETIME" >> $GITHUB_OUTPUT
|
|
echo "ARTIFACTS_DIR=$ARTIFACTS_DIR" >> $GITHUB_OUTPUT
|
|
echo "ARTIFACTS_URL=$ARTIFACTS_URL" >> $GITHUB_OUTPUT
|
|
|
|
- name: Set commit status as pending
|
|
if: contains(needs.prepare_vars.outputs.supported_platforms, matrix.platform)
|
|
uses: myrotvorets/set-commit-status-action@master
|
|
with:
|
|
sha: ${{ needs.prepare_vars.outputs.head_sha }}
|
|
status: pending
|
|
context: ${{ matrix.platform }}|ansible-${{ matrix.ansible_version }}
|
|
description: Test started
|
|
targetUrl: ""
|
|
|
|
- name: Set commit status as success with a description that platform is skipped
|
|
if: "!contains(needs.prepare_vars.outputs.supported_platforms, matrix.platform)"
|
|
uses: myrotvorets/set-commit-status-action@master
|
|
with:
|
|
sha: ${{ needs.prepare_vars.outputs.head_sha }}
|
|
status: success
|
|
context: ${{ matrix.platform }}|ansible-${{ matrix.ansible_version }}
|
|
description: The role does not support this platform. Skipping.
|
|
targetUrl: ""
|
|
|
|
- name: Run test in testing farm
|
|
uses: sclorg/testing-farm-as-github-action@v3
|
|
if: contains(needs.prepare_vars.outputs.supported_platforms, matrix.platform)
|
|
with:
|
|
git_url: https://github.com/linux-system-roles/tft-tests
|
|
git_ref: main
|
|
pipeline_settings: '{ "type": "tmt-multihost" }'
|
|
environment_settings: '{ "provisioning": { "tags": { "BusinessUnit": "system_roles" } } }'
|
|
# Keeping ARTIFACTS_URL at the bottom makes the link in logs clickable
|
|
variables: "ANSIBLE_VER=${{ matrix.ansible_version }};\
|
|
REPO_NAME=${{ github.event.repository.name }};\
|
|
GITHUB_ORG=${{ github.repository_owner }};\
|
|
PR_NUM=${{ github.event.issue.number }};\
|
|
ARTIFACTS_DIR=${{ steps.set_vars.outputs.ARTIFACTS_DIR }};\
|
|
TEST_LOCAL_CHANGES=false;\
|
|
LINUXSYSTEMROLES_USER=${{ vars.LINUXSYSTEMROLES_USER }};\
|
|
ARTIFACTS_URL=${{ steps.set_vars.outputs.ARTIFACTS_URL }}"
|
|
# Note that LINUXSYSTEMROLES_SSH_KEY must be single-line, TF doesn't read multi-line variables fine.
|
|
secrets: "LINUXSYSTEMROLES_DOMAIN=${{ secrets.LINUXSYSTEMROLES_DOMAIN }};\
|
|
LINUXSYSTEMROLES_SSH_KEY=${{ secrets.LINUXSYSTEMROLES_SSH_KEY }}"
|
|
compose: ${{ matrix.platform }}
|
|
# There are two blockers for using public ranch:
|
|
# 1. multihost is not supported in public https://github.com/teemtee/tmt/issues/2620
|
|
# 2. Security issue that leaks long secrets - Jira TFT-2698
|
|
tf_scope: private
|
|
api_key: ${{ secrets.TF_API_KEY_RH }}
|
|
update_pull_request_status: false
|
|
tmt_hardware: '{ "memory": ">= ${{ needs.prepare_vars.outputs.memory }} MB" }'
|
|
tmt_plan_filter: "tag:general,aide"
|
|
|
|
- name: Set final commit status
|
|
uses: myrotvorets/set-commit-status-action@master
|
|
if: always() && contains(needs.prepare_vars.outputs.supported_platforms, matrix.platform)
|
|
with:
|
|
sha: ${{ needs.prepare_vars.outputs.head_sha }}
|
|
status: ${{ job.status }}
|
|
context: ${{ matrix.platform }}|ansible-${{ matrix.ansible_version }}
|
|
description: Test finished
|
|
targetUrl: ${{ steps.set_vars.outputs.ARTIFACTS_URL }}
|